When doing a code review interview or even looking in the code review for the team the following steps can be used
- Look into the main logic first
- Understand the complete code
- Check for Time and Space complexity. Can we make it better ?
- Check if alternate data structure can be used ?
- Can the Dependency Injection and Inversion of Control be used ?
- Is there code redundancy or code duplication ?
- Will the code work with concurrency ?
- Naming Conventions
- Readability of the code
- Check if the Logging (Error, Debug, Info) is properly done?
- Check if the Constants can be moved ?
- Can we apply any design patterns to make the code more readable
- Check if it is easy to write the unit test for the code ?
- Unit testing
- Comments added to the code ?
- IO calls are expensive. Use caching, request collapsing and batch queries to reduce load.
Google Code Review Standards
Videos to watch before a Code Review Interview :
Good Reads :
No comments:
Post a Comment